[llvm-commits] Stub for LLVM-based sanitizer for ASan/TSan tools. (issue 6258065)

[dvyukov at google.com]

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h
File lib/sanitizer_common/symbolizer.h (right):

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h#newcode1
lib/sanitizer_common/symbolizer.h:1: //===-- symbolizer.h
--------------------------------------------*- C++ -*-===//
Let's prefix files in sanitizer_common with some prefixes.

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h#newcode12
lib/sanitizer_common/symbolizer.h:12: #ifndef SYMBOLIZER_H
I would put the prefix here as well.

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h#newcode19
lib/sanitizer_common/symbolizer.h:19: typedef unsigned long uptr;
Move this to another file.

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h#newcode23
lib/sanitizer_common/symbolizer.h:23: char *module;
What are these pointers? Who frees them? What is the lifetime?

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h#newcode31
lib/sanitizer_common/symbolizer.h:31: class Symbolizer {
Are you going to use pimpl?

http://codereview.appspot.com/6258065/diff/1/lib/sanitizer_common/symbolizer.h#newcode36
lib/sanitizer_common/symbolizer.h:36: bool SymbolizeCode(uptr address,
AddressInfo* info);
It must return a set of AddressInfo's with inlining info.

http://codereview.appspot.com/6258065/