[llvm-commits] [PATCH] Add support for functions with VLAs and dynamic stack realignment on x86

Anton Korobeynikov anton at korobeynikov.info
Wed May 30 15:02:23 PDT 2012


Hi Chad,

> The ABI specifies a default alignment of 16-bytes, which has been enough in general.  However, AVX code commonly requires 32-byte alignment, so as we move forward with AVX support this fix will become more critical.  We currently generate miscompiled code in these rare cases (without warning).  The attached solution is the same as that used for the ARM backend.  Specifically, an additional
Thanks for working on this! Few comments:

1. Make sure stuff works on x86-32 + PIC
2. What's about unwinding and debug info? Can debugger see the values
wrt base register? Is ebx restored when exception is raised and stack
is unwound?

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list