[llvm-commits] [cfe-commits] [PATCH] Add llvm.fmuladd intrinsic.

[Matthieu Monrocq]

On Wed, May 30, 2012 at 9:20 AM, Lang Hames <lhames at gmail.com> wrote:

> Agreed - Legal was a poor choice of terms. I don't know if we want to
>> check TLI.isOperationLegal(...) though - an llvm.fma.* call (which is what
>> we lower to) will always be legal...
>>
>
> Owen pointed out that I'm finding new and interesting ways to abuse the
> term 'legal' here. To clarify: If isFMACheap returns true we should
> legalize the llvm.fmuladd.* to an llvm.fma.* and leave it to the existing
> legalization code to turn the llvm.fma.* into something sane for the target.
>
> - Lang.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
Hello Lang,

I only have one nits: I think you'll need Doug's approval for adding a bit
flag into FunctionDecl (especially since this is such a specialized
construct).

I added him in case he missed the discussion.

-- Matthieu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120530/7edd30b4/attachment.html>