[llvm-commits] Bug in promoting types in RetCC

Yiannis Tsiouris gtsiour at softlab.ntua.gr
Fri May 25 04:22:45 PDT 2012


On 05/25/2012 01:54 AM, Jakob Stoklund Olesen wrote:
> On 05/21/2012 02:20 AM, Yiannis Tsiouris wrote:
>>> Hi,
>>>
>>> As discussed in this thread [1, 2], there seems to be a bug in promoting
>>> types in a RetCC. The attached patch fixes this. There is no unit-test
>>> attached because no RetCC uses CCPromoteToType nowadays. I noticed this
>>> trying to write a unit-test for a patch that inserts custom prologue
>>> code for the HiPE compiler (to be submitted for review as soon as the
>>> HiPE CC patch is accepted).
>>>
>>> If there is something wrong in the attached patch or the patch in [1],
>>> please let me know! :-)
> The patch appears to break most of the X86 unit tests.
>
> /jakob
Sorry, for that! The attached should work.

~y.

-- 
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: http://www.softlab.ntua.gr/~gtsiour

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-promote-in-retcc-bug-v2.patch
Type: text/x-diff
Size: 1074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120525/c960d8a5/attachment.patch>


More information about the llvm-commits mailing list