[llvm-commits] [PATCH] [asan] Use zero-based shadow by default on Android

Evgeniy Stepanov eugeni.stepanov at gmail.com
Wed May 23 03:58:35 PDT 2012


Note that this change will require building binaries with -fPIE -pie.
I believe there is really no way around this. We can not change shadow
location on a per-binary basic because of the shared runtime, and
there is no universal location that fit both PIE and non-PIE.

I'm going to land this soon, then add some runtime checks to ensure
that the shadow does not silently override any preexisting mappings.

On Tue, May 22, 2012 at 6:43 PM, Kostya Serebryany <kcc at google.com> wrote:
> Both look good, thanks!
> --kcc
>
> On Tue, May 22, 2012 at 6:38 PM, Evgeniy Stepanov
> <eugeni.stepanov at gmail.com> wrote:
>>
>> Hi,
>>
>> these patches (one to llvm, another to compiler-rt) change ASan
>> default shadow offset on Android to zero. This seems to marginally
>> improve performance of Thumb code, significantly (~5%) saves code
>> size, and avoids address space collisions with the main executable in
>> a non-ASLR case.
>>
>> Please review.
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>



More information about the llvm-commits mailing list