[llvm-commits] mips16 patch 3

[reed kotler]

On 05/18/2012 10:07 PM, Jim Grosbach wrote:
> Won't HasMips32() return true even when compiling in mips16 mode? That is, whether the processor supports mips32 is orthogonal to which mode you're compiling for.
>
> For example, in the ARM backend, see hasThumb2() vs. isThumb2().
>
> -Jim
>
> On May 18, 2012, at 6:46 PM, reed kotler wrote:
>
>> This patch adds a predicate to existing mips32 and mips64 so that those instruction encodings can be excluded during mips16 processing.
>>
>> No additional testing is needed other than to assure that there is no regression from this patch.
>> <mips16_patch3.txt>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
I think the correct hasStandardEncoding should be

bool hasStandardEncoding() const { return !inMips16Mode(); }

when i add micromips it would bebool has

StandardEncoding() const { return !inMips16Mode() && !inMicroMipsMode(); }