[llvm-commits] [PATCH] Make dependency DAG construction to use AA

[Andrew Trick]

On May 11, 2012, at 9:59 AM, Sergei Larin <slarin at codeaurora.org> wrote:
>  Here is the latest patch version, addressing your comments. I still call
> getUnderlyingObject() for reasons mentioned in comments.
> It does look cleaner that way, so hopefully we are getting closer to being
> done.
> 
> Sergei
> 
> <patch_aa_in_dag_v3.patch>

Sergei, I think this is committable now. Two minor comments.

+  // Is this pointer refers to
Grammar

+  // TODO: Need to handle multiple memory operands.
+  assert(MIa->hasOneMemOperand() && "Multiple memory operands.");
I think assert should only be for things that can't happen in theory. For unimplemented pieces I suggest something like llvm_unreachable that triggers in a release build.

-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120515/10e62e1c/attachment.html>