[llvm-commits] [PATCH] Missing bit definition for STR post reg instruction on ARM

Silviu Baranga silbar01 at arm.com
Thu May 10 09:41:49 PDT 2012


Hi,

 

The 4th bit of the STR (post reg) instruction in the ARM backend is
currently not defined. It should be set

to 0. This is causing other instructions(such as SEL) to be disassembled as
STR instructions. The patch

adds the missing definition. 

 

The instructions that were being wrongly disassembled as STR instructions
also had missing unpredictable  

bitfield specifications. The patch also sets the bits in the "Unpredictable"
mask for these instructions.

 

We add regression tests for all the affected instructions.

 

Please review this patch.

 

Thanks,

Silviu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120510/b0568479/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sel.diff
Type: application/octet-stream
Size: 3273 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120510/b0568479/attachment.obj>


More information about the llvm-commits mailing list