[llvm-commits] [llvm] r156150 - /llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

[Rafael Espíndola]

On 4 May 2012 11:34, Tom Care <tom.care at uqconnect.edu.au> wrote:
> Hi Rafael,
>
> This change will break things for a few people. Eclipse CDT and possibly other clients don't handle ANSI codes well and this can break diagnostic parsing. There should be a way to explicitly disable colour diagnostics for non-ANSI aware clients.
>
> Perhaps a workaround is to make this dependent on the CMAKE_COLOR_MAKEFILE flag, since it would be strange to have no colour for the makefiles but still have colour for diagnostics. The flag description seems to refer to the whole build process rather than just the makefiles so it seems appropriate enough.

Sorry for breaking it.

I tried using

   if( SUPPORTS_FCOLOR_DIAGNOSTICS_FLAG AND CMAKE_COLOR_MAKEFILE )

but looks like that is always false. Is this the right way to use
CMAKE_COLOR_MAKEFILE? Would it be OK if I just added a
LLVM_DISABLE_COLOR_DIAGNOSTICS?

> Tom

Cheers,
Rafael