[llvm-commits] Polly cleanup patches in preparation for the new ISL code generator

Tobias Grosser tobias at grosser.es
Sun May 6 02:05:30 PDT 2012


On 05/06/2012 04:31 AM, Sebastian Pop wrote:
> On Fri, May 4, 2012 at 1:13 PM, Sebastian Pop<spop at codeaurora.org>  wrote:
>> We will then conditionally compile CodeGeneration.cpp following
>> the availability of CLooG, and IslCodeGeneration.cpp following the
>> availability of isl/codegen.h
>>
>> I will prepare patches for this.
>
> Here is the patch for the second part: check that ISL codegen.h exists
> and conditionally compile IslCodeGeneration.cpp.  I will be adding this
> file when I will have an implementation ready.
>
> Tested with and without the ISL codegen with cmake and configure.
> Ok to commit this patch?

Looks good. I would prefer if you could include with this patch a dummy 
implementation of IslCodegen (just a file with the copyright header and 
a short description of what it will be doing). Without an actual file 
the cmake build will break if isl/codegen.h is available, but 
IslCodeGeneration.cpp not yet.

Tobi



More information about the llvm-commits mailing list