[llvm-commits] Polly cleanup patches in preparation for the new ISL code generator

[Tobias Grosser]

On 05/04/2012 08:37 PM, Sebastian Pop wrote:
> On Fri, May 4, 2012 at 1:13 PM, Sebastian Pop<spop at codeaurora.org>  wrote:
>> >  We will then conditionally compile CodeGeneration.cpp following
>> >  the availability of CLooG
> Please review the attached patch that implements this.

Looks good except some minor nits. OK to commit, if you address them:

> diff --git a/include/polly/LinkAllPasses.h b/include/polly/LinkAllPasses.h
> index 34b6c59..ced5d48 100644
> --- a/include/polly/LinkAllPasses.h
> +++ b/include/polly/LinkAllPasses.h
> @@ -29,8 +29,10 @@ using namespace llvm;
>
>   namespace polly {
>     Pass *createAffSCEVItTesterPass();
> +#ifdef CLOOG_FOUND
>     Pass *createCloogExporterPass();
>     Pass *createCloogInfoPass();
> +#endif
>     Pass *createCodeGenerationPass();

Include createCodeGenerationPass also in the #ifdef


> +#ifdef CLOOG_FOUND
>          createCloogExporterPass();
>          createCloogInfoPass();
> +#endif
>          createCodeGenerationPass();
Include createCodeGenerationPass also in the #ifdef

> diff --git a/lib/RegisterPasses.cpp b/lib/RegisterPasses.cpp
> index 5838136..51835a0 100644
> --- a/lib/RegisterPasses.cpp
> +++ b/lib/RegisterPasses.cpp
> @@ -106,7 +106,9 @@ CFGPrinter("polly-view-cfg",
>          cl::init(false));
>
>   static void initializePollyPasses(PassRegistry&Registry) {
> +#ifdef CLOOG_FOUND
>     initializeCloogInfoPass(Registry);
> +#endif
>     initializeCodeGenerationPass(Registry);
Include createCodeGenerationPass also in the #ifdef

Tobi