[llvm-commits] [PATCH] Make ARM and Mips use TargetMachine::getTLSModel()

Hans Wennborg hans at chromium.org
Fri May 4 02:44:30 PDT 2012


On Thu, May 3, 2012 at 8:56 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On May 3, 2012, at 12:55 PM, Tim Northover <t.p.northover at gmail.com> wrote:
>
>> On Thu, May 3, 2012 at 5:38 PM, Eric Christopher <echristo at apple.com> wrote:
>>> Yeah, I think this will be ok. I don't have all of the details of ARM ELF TLS memorized though,
>>> but I'm willing to go with James's opinion there :)
>>
>> I don't think we redefine the categories, and according to those
>> categories the patch looks fine to me too. getTLSModel itself is a
>> little sketchy, but as a set of defaults while we work out something
>> more complete it also looks reasonably sane.
>
> Yeah. I didn't see the original TLS support go in for ARM (at least I don't think so) and willing to let you guys play with it a bit :)

Thanks everyone for looking! Landed r156162.

 - Hans



More information about the llvm-commits mailing list