[llvm-commits] Polly cleanup patches in preparation for the new ISL code generator

[Tobias Grosser]

On 05/03/2012 05:08 PM, Sebastian Pop wrote:
> On Wed, May 2, 2012 at 11:22 AM, Tobias Grosser<tobias at grosser.es>  wrote:
>> Yes, please commit.
>
> Thanks.
>
> The second patch splits the clast code generator from CodeGeneration.cpp
> into Clast.cpp.  I have put the clast_expr and clast_stmt code generator classes
> in Cloog.h: this way we can isolate all the CLooG functionality, and include
> Cloog.h conditionally on #ifdef CLOOG_FOUND that is defined at configure time
> (third patch).  For the moment I have left CLooG as "required" in the configure
> script, we will lower the status of CLooG when we will be happy with the new ISL
> code generator.

I don't see a second patch. You reattached the third one.

Another option I could see is to keep the CodeGeneration.cpp file as it 
is and build in parallel the IslCodeGenerator class. You could choose 
the CodeGenerator to schedule in RegisterPasses.cpp. The advantage I see 
here is that you could start from scratch, without the need of having 
everything working from the start. You can especially skip the OpenMP 
and Vector codegeneration pieces. Shared functionality could be 
extracted in helper classes and could be used by both passes.

Tobi