[llvm-commits] PR12385 PATCH: Missed constant propagation in loops

Dan Gohman gohman at apple.com
Thu May 3 12:51:43 PDT 2012


On May 2, 2012, at 11:09 PM, Evan Cheng <evan.cheng at apple.com> wrote:
> 
> Dan, can you review this? Comments?

Is there anything motivating this patch other than the given
testcase? It seems like the patch adds a disproportionate amount
of code and complexity.

Also, from the description, the algorithm sounds a lot like
it's trying to do something very similar towhat LLVM's GVN pass does.
Have you looked at GVN, and do you know why it is unable to optimize
this testcase?

Dan




More information about the llvm-commits mailing list