[llvm-commits] [llvm] r155925 - /llvm/trunk/lib/MC/MCParser/AsmParser.cpp

Jim Grosbach grosbach at apple.com
Tue May 1 11:38:24 PDT 2012


Author: grosbach
Date: Tue May  1 13:38:24 2012
New Revision: 155925

URL: http://llvm.org/viewvc/llvm-project?rev=155925&view=rev
Log:
MC: Remove errant EatToEndOfStatement() in asm parser.

The caller is already responsible for eating any additional input on the
line. Putting an additional EatToEndOfStatement() in ParseStatement()
causes an entire extra statement to be consumed when treating warnings
as errors. For example, test/MC/macros.s will assert() because the
.endmacro directive is missed as a result.

rdar://11355843

Modified:
    llvm/trunk/lib/MC/MCParser/AsmParser.cpp

Modified: llvm/trunk/lib/MC/MCParser/AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCParser/AsmParser.cpp?rev=155925&r1=155924&r2=155925&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCParser/AsmParser.cpp (original)
+++ llvm/trunk/lib/MC/MCParser/AsmParser.cpp Tue May  1 13:38:24 2012
@@ -1238,9 +1238,7 @@
     if (!getTargetParser().ParseDirective(ID))
       return false;
 
-    bool retval = Warning(IDLoc, "ignoring directive for now");
-    EatToEndOfStatement();
-    return retval;
+    return Warning(IDLoc, "ignoring directive for now");
   }
 
   CheckForValidSection();





More information about the llvm-commits mailing list