[llvm-commits] [cfe-commits] Please review: Hexagon V5 (floating point) support in cfe

Douglas Gregor dgregor at apple.com
Mon Apr 30 16:56:00 PDT 2012


On Apr 25, 2012, at 10:15 PM, Sirish Pande <spande at codeaurora.org> wrote:

> Hi,
> 
> This is the support for floating point in Hexagon V5 architecture in cfe.
> 
> This patch does not give warnings, and passes all tests with make check-all.

Patch looks generally fine, but could you split it into two parts before committing? The first part would be the interesting changes (target description string, defines, driver stuff) and the second part would be the massive churn in BuiltinsHexagon.def/CGBuiltin.cpp

	- Doug



More information about the llvm-commits mailing list