[llvm-commits] [PATCH][RFC] NVPTX Backend

[Justin Holewinski]

Thanks for the feedback!

The attached patch addresses the style issues that have been found.

From: Jim Grosbach [mailto:grosbach at apple.com]
Sent: Wednesday, April 25, 2012 2:22 PM
To: Justin Holewinski
Cc: llvm-commits at cs.uiuc.edu; llvmdev at cs.uiuc.edu; Vinod Grover
Subject: Re: [llvm-commits] [PATCH][RFC] NVPTX Backend

Hi Justin,

Cool stuff, to be sure. Excited to see this.

As a pre-cursor to more involved technical feedback, I suggest going through and fixing up the coding style and formatting issues. Just glancing through, I see lots of things like function names starting with capital letters, compound statements with the opening brace on the line following an if/for/while/etc., single-statements after an 'if' enclosed in a compound statement, container.end() being evaluated every iterations of loops, etc, etc..

-Jim

On Apr 24, 2012, at 11:50 AM, Justin Holewinski <jholewinski at nvidia.com<mailto:jholewinski at nvidia.com>> wrote:


Hi LLVMers,

We at NVIDIA would like to contribute back to the LLVM open-source community by up-streaming the NVPTX back-end for LLVM.  This back-end is based on the sources used by NVIDIA, and currently provides significantly more functionality than the current PTX back-end.  Some functionality is currently disabled due to dependencies on LLVM core changes that we are also in the process of up-streaming, but the back-end is very usable in its current state and would benefit all current and future users of the LLVM PTX back-end.

The goal is to phase out the existing PTX back-end, while maintaining compatibility with it.  To that end, the NVPTX back-end maintains its own set of intrinsics but also supports the old PTX back-end intrinsics to ensure compatibility with out-of-tree users.

We would like to get your feedback on the attached patch to make sure it is up to LLVM commit quality.  We would like to commit this as soon as the community is satisfied with it.

Also, as the current maintainer of the PTX back-end, I give my consent to deprecate it. :)


Thanks,

Justin Holewinski

________________________________
This email message is for the sole use of the intended recipient(s) and may contain confidential information.  Any unauthorized review, use, disclosure or distribution is prohibited.  If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
________________________________

<nvptx-backend-public.patch>_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120427/8f219f70/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvptx-backend-public.patch
Type: application/octet-stream
Size: 1026178 bytes
Desc: nvptx-backend-public.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120427/8f219f70/attachment.obj>