[llvm-commits] [PATCH] MC cannot assemble IT instructions with an UPPER CASE IT condition

Richard Barton richard.barton at arm.com
Fri Apr 27 10:37:03 PDT 2012


Hi Jim

Fastest code review ever!

Committed in r155720.

Thanks
Rich

> -----Original Message-----
> From: Jim Grosbach [mailto:grosbach at apple.com]
> Sent: 27 April 2012 18:02
> To: Richard Barton
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] MC cannot assemble IT instructions with an UPPER CASE IT
> condition
> 
> LGTM. Please apply. Thanks!
> 
> -Jim
> 
> On Apr 27, 2012, at 10:01 AM, Richard Barton <richard.barton at arm.com> wrote:
> 
> > [Patch attached this time ;-)]
> >
> > Hello reviewers
> >
> > The attached patch fixes the ARM assembler to understand upper case
> condition
> > codes in IT instructions.
> >
> > It is a simple change to lower case the condition code operand, before
> matching.
> > The similar code to parse the condition code on a mnemonic passes because
> the
> > mnemonic is lower cased before matching.
> >
> > Please review.
> >
> > Thanks
> > Rich
> >
> > Richard Barton
> > Senior Engineer - Compilation Tools
> > ARM Ltd, Cambridge
> > 01223 400864
> >
> >
> > <IT_upper_case_condition_codes.patch>
> 
> 







More information about the llvm-commits mailing list