[llvm-commits] [PATCH] Refactor MCInst operands for Thumb IT instruction

[Bill Wendling]

Hi Richard,

I may need one of the ARM guys to chime in here. My only question is about how you're getting the "Firstcond" value in ARMInstPrinter.cpp. You're doing this:

	unsigned Firstcond = MI->getOperand(OpNum-1).getImm();

Does this mean that the Mask and Firstcond information are both in the operand list? And that when we created the mask and combined the two? If so, that's gross...

-bw

On Apr 24, 2012, at 4:45 AM, Richard Barton <richard.barton at arm.com> wrote:

> Hi Bill
> 
> I'm taking you up on your invitation for more patch reviews in the area of IT
> instructions. 
> 
> The attached patch removes the slightly hacky use of the mask operand for IT
> instructions. Currently, the IT Mask operand is stored as the 4 mask bits and
> the bottom bit of the condition code field. My patch stores the mask as just the
> actual mask operand only and fetches the condition code operand separately in a
> similar way to printers for other instructions.
> 
> Please review.
> 
> Richard Barton
> 
> <IT_refactoring_mask_operand.patch>