[llvm-commits] [lld] [PATCH] "friend class" fixes

[Nick Kledzik]

On Apr 25, 2012, at 5:53 AM, Jay Foad wrote:
> Hi,
> 
> When building lld with gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 I get:
> 
> [100%] Building CXX object
> projects/lld/lib/Platforms/Darwin/CMakeFiles/lldDarwinPlatform.dir/ExecutableWriter.cpp.o
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:338:3:
> error: a class-key must be used when declaring a friend
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:338:3:
> error: friend declaration does not name a class or function
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:339:3:
> error: a class-key must be used when declaring a friend
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:339:3:
> error: friend declaration does not name a class or function
> 
> The attached patch fixes this. OK to commit?
Yes.

Is this something clang should be warning about too?  

-Nick