[llvm-commits] [llvm] r155364 - in /llvm/trunk: include/llvm/CodeGen/DFAPacketizer.h lib/CodeGen/DFAPacketizer.cpp

[Chandler Carruth]

On Mon, Apr 23, 2012 at 11:09 AM, Sirish Pande <spande at codeaurora.org>wrote:

>  There were only two reviews:
>
> 1. Eric C asked for test cases, and that test cases be associated with the
> patch.
> 2. Tom Stellard had requested to split the vliw packetizer patch.
>
> Both have been done.
>

But the review isn't finished yet. You need to wait for the reviewers to
actually sign off on the change before submitting. The two comments you got
were what people needed changed based on their first look, that doesn't
mean the code is ready to be submitted yet.

This patch is particularly problematic because it is not just changing the
Hexagon, it's changing a core part of the codegen layer. Those changes need
proper review before being committed, and that hasn't happened yet.

I've reverted this patch until the review finishes because the patches
requiring it had to be reverted anyways.

I reverted the hexagon patches because your own regression tests failed for
all of the patches in the series.

This gets the tree back into both a reviewed and test-passing state. Let's
keep it that way. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120423/3735e098/attachment.html>