[llvm-commits] Please Review: ZERO_EXTEND/SIGN_EXTEND/TRUNCATE optimization for AVX2

Craig Topper craig.topper at gmail.com
Thu Apr 19 10:50:10 PDT 2012


On Thu, Apr 19, 2012 at 10:29 AM, Chad Rosier <mcrosier at apple.com> wrote:

> Mostly stylistic comments:
>
> +      SmallVector<SDValue,32> pshufbMask;
> +      for (unsigned i=0; i<2; i++) {
>
> Spacing: for (unsigned i = 0; i < 2; i++)
>

That should also be "++i" to match coding standards.

I'll try to review the content tonight.

-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120419/a9c465f4/attachment.html>


More information about the llvm-commits mailing list