[llvm-commits] [llvm] r155014 - /llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp

[Jim Grosbach]

On Apr 18, 2012, at 11:26 AM, Jakub Staszak wrote:

> 
> On Apr 18, 2012, at 7:46 PM, Jim Grosbach wrote:
> 
>> 
>> +      PrintWarning(Inst.TheDef->getLoc(),
>> +                   Twine("Warning: mayStore flag explicitly set on ") +
>> +                   "instruction, but flag already inferred from pattern.\n");
> 
> I think it  would be cheaper to write it as:
>      PrintWarning(Inst.TheDef->getLoc(),
>                   "Warning: mayStore flag explicitly set on "
>                   "instruction, but flag already inferred from pattern.\n");

Quite right, of course. There was originally some non-constant text in between there, but I removed it as redundant w/ the source location info. Totally missed that it became all constant as a result. Will fix.

Thanks!

-Jim