[llvm-commits] [llvm] r154616 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/ lib/Target/Hexagon/ lib/Target/Hexagon/InstPrinter/ lib/Target/Hexagon/MCTargetDesc/

[Jim Grosbach]

On Apr 18, 2012, at 8:39 AM, Jakob Stoklund Olesen wrote:

> 
> On Apr 16, 2012, at 5:58 AM, Sirish Pande wrote:
> 
>> Instead of specifying mayLoad and mayStore for every pattern that does 
>> not have ISD::load or ISD::store, I am  using mayLoad and mayStore in 
>> Instruction Format definitions. This causes "double" definitions on the 
>> patterns that use the ISD::load/store and Instruction Format definitions 
>> that use mayLoad/mayStore.  I believe the real solution is somewhere in 
>> the tablegen itself.
> 
> The TableGen warning is not misfiring. It is telling you: "That thing you are doing, don't do it." Someone put that warning there for a reason. Why do you assume it is a problem with TableGen?
> 
> Please fix this immediately by either reverting your patch, or by placing mayLoad/mayStore flags only on the instructions that need it instead of in your instruction format class.
> 
> If you think the warning is wrong, send a message to llvm-dev, and we can discuss it.
> 
> Committing a patch that triggers dozens of warnings for everybody is not the right way of starting that discussion.


+1.

FWIW, I just added additional information to those diagnostics that may make things easier to track down. Specifically, you they now contain source location information.

-Jim