[llvm-commits] Patch to FileCheck-ize test/Transforms/SimplifyLibCalls/floor.ll and remove obsolete XFAILs

[Eli Friedman]

On Tue, Apr 17, 2012 at 5:23 PM, Joe Groff <arcata at gmail.com> wrote:
> Hi everyone. Here's a patch for
> test/Transforms/SimplifyLibCalls/floor.ll to have it use FileCheck,
> and remove some XFAILs that are no longer necessary now that
> SimplifyLibCalls uses TargetLibraryInfo instead of autoconf defines. I
> also augmented the test with additional checks that `round` does or
> does not simplify based on target availability. This patch should fix
> the broken build at
> http://bb.pgr.jp/builders/cmake-clang-i686-msvc10/builds/2434 . Let me
> know if you all recommend any other updates to the test. Thanks.

In the FileCheck lines, I'd suggest checking for "call float @floor("
and "call float @floorf("; then you don't need the CHECK-NOT lines.

Otherwise, looks fine.

-Eli