[llvm-commits] [llvm] r154857 - /llvm/trunk/test/CodeGen/ARM/widen-vmovs.ll

[Chandler Carruth]

On Mon, Apr 16, 2012 at 11:25 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Apr 16, 2012, at 2:18 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
> On Mon, Apr 16, 2012 at 10:49 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:
>
>> Author: stoklund
>> Date: Mon Apr 16 15:49:06 2012
>> New Revision: 154857
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=154857&view=rev
>> Log:
>> Disable code placement for this test.
>>
>> It makes it less sensitive to small changes in heuristics.
>>
>
> Cool, should I go back and do this to all the tests I had to update with
> the code placement flip? I wasn't sure it was worth it, and I wasn't aware
> we already had an option for this.
>
>
> I am not sure what is the right approach. Ideally, code placement should
> be less sensitive to small changes, and we wan't to keep you honest by
> having a bunch of tests fail when you randomly shuffle blocks.
>
> How about disabling it only for the metastable tests? The ones that seem
> to flip between equally good solutions.
>

That sounds good to me.

My particular flip was... not "equally good" but "radically different", but
this should be a good rubrik for future changes and tweaks. =] Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120416/583f3581/attachment.html>