[llvm-commits] [PATCH] Fix PR12274 - bad EXTRACT_SUBREG in isel

[Stephen Hines]

I tested the patch and it does indeed fix the original bug (passing all
local tests as well). Please go ahead and submit.

Thanks,
Steve

On Thu, Apr 5, 2012 at 8:07 AM, James Molloy <james.molloy at arm.com> wrote:

>  Hi,****
>
> ** **
>
> The attached patch fixes PR12274, an assertion failure firing when an ARM
> NEON pattern is hit.****
>
> ** **
>
> The bug is with code I submitted myself as part of the fix for PR11836 and
> is trivial, so I don’t know if I could have just committed without
> pre-review. Perhaps someone could advise about that for the future?****
>
> ** **
>
> The problem is the pattern creating an EXTRACT_SUBREG node from a Qreg
> asking for a qsub_0, which I thought would be fine but apparently is not (I
> didn’t realise a no-op/identity extract_subreg like that would fail). My
> original testcases also failed to cover it L****
>
> ** **
>
> OK to commit?****
>
> ** **
>
> Cheers,****
>
> ** **
>
> James****
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120416/2be669e7/attachment.html>