[llvm-commits] [llvm] r154838 - in /llvm/trunk: lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp test/MC/Mips/sym-offset.ll

[Akira Hatanaka]

Author: ahatanak
Date: Mon Apr 16 13:00:19 2012
New Revision: 154838

URL: http://llvm.org/viewvc/llvm-project?rev=154838&view=rev
Log:
Do not add offset in applyFixup. This has already been accounted for in Value. 


Added:
    llvm/trunk/test/MC/Mips/sym-offset.ll
Modified:
    llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp

Modified: llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp?rev=154838&r1=154837&r2=154838&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp Mon Apr 16 13:00:19 2012
@@ -12,7 +12,6 @@
 //===----------------------------------------------------------------------===//
 //
 
-#include "MipsBaseInfo.h"
 #include "MipsFixupKinds.h"
 #include "MCTargetDesc/MipsMCTargetDesc.h"
 #include "llvm/MC/MCAsmBackend.h"
@@ -85,9 +84,8 @@
                   uint64_t Value) const {
     MCFixupKind Kind = Fixup.getKind();
     Value = adjustFixupValue((unsigned)Kind, Value);
-    int64_t SymOffset = MipsGetSymAndOffset(Fixup).second;
 
-    if (!Value && !SymOffset)
+    if (!Value)
       return; // Doesn't change encoding.
 
     // Where do we start in the object
@@ -118,7 +116,7 @@
     }
 
     uint64_t Mask = ((uint64_t)(-1) >> (64 - getFixupKindInfo(Kind).TargetSize));
-    CurVal |= (Value + SymOffset) & Mask;
+    CurVal |= Value & Mask;
 
     // Write out the fixed up bytes back to the code/data bits.
     for (unsigned i = 0; i != NumBytes; ++i) {

Added: llvm/trunk/test/MC/Mips/sym-offset.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Mips/sym-offset.ll?rev=154838&view=auto
==============================================================================
--- llvm/trunk/test/MC/Mips/sym-offset.ll (added)
+++ llvm/trunk/test/MC/Mips/sym-offset.ll Mon Apr 16 13:00:19 2012
@@ -0,0 +1,22 @@
+; RUN: llc -filetype=obj -mtriple mipsel-unknown-linux %s -o - | elf-dump --dump-section-data  | FileCheck %s
+
+; FIXME: use assembler instead of llc when it becomes available.
+
+ at string1 = internal global [11 x i8] c"aaaaaaaaaa\00", align 1
+ at string2 = internal global [10 x i8] c"aaaa\00bbbb\00", align 1
+
+define i32 @foo1(i32 %n) nounwind readonly {
+entry:
+; check that the immediate fields of lwl and lwr are three apart.
+; 8841000e        lwl     at,14(v0)
+; 9841000b        lwr     at,11(v0)
+
+; CHECK: ('_section_data', '00001c3c 00009c27 21e09903 0000828f 0e004188 0b004198
+
+  %call = tail call i32 @memcmp(i8* getelementptr inbounds ([11 x i8]* @string1, i32 0, i32 0), i8* getelementptr inbounds ([10 x i8]* @string2, i32 0, i32 0), i32 4) nounwind readonly
+  %cmp = icmp eq i32 %call, 0
+  %conv = zext i1 %cmp to i32
+  ret i32 %conv
+}
+
+declare i32 @memcmp(i8* nocapture, i8* nocapture, i32) nounwind readonly