[llvm-commits] [PATCH] Review request - MCJIT GDB source level debugging support

[Eric Christopher]

On Apr 16, 2012, at 10:58 AM, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:

> Hi Eric,
> 
> Thanks for the review.
> 
> The ObjectBuffer type definition is in the jitdebugging namespace because it was a more-or-less arbitrary type definition used only in the JIT debugging interface.  I suppose we could get rid of it completely and just use one of the standard types.
> 

*shrug* :)

> I intended the two functions declared in JITRegistrar.h as the abstraction point, but I suppose I can see the value of moving an abstract JITRegistrar class into that file and providing a static function to get a GDB-specific registrar singleton.  So JITRegistrar.h would look something like this:
> 
> --------------
> 
> class JITRegistrar {
> public:
>  JITRegistrar() {}
>  virtual ~JITRegistrar() {}
> 
>  void registerObject(const StringRef Object) = 0;
>  void deregister(const StringRef Object) = 0;
> 
>  static JITRegistrar& GDBJITRegistrar();
> }
> 
> --------------
> 
> Is that kind of what you had in mind?  If so, I'd probably still leave the JITRegistrar.cpp implementation more less as it is and just rename the file.

Yeah. That sounds about right.

Thanks!

-eric