[llvm-commits] [PATCH] Review request - MCJIT GDB source level debugging support

[Eric Christopher]

On Apr 12, 2012, at 6:40 PM, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:

> The attached patch implements GDB integration for source-level debugging of code JITed using the MCJIT execution engine.
>  

Few comments:

Why is ObjectBuffer in jitdebugging? Seems a bit odd.
You don't need to indent lines 2-n of a comment any more than the first line.
Since we'll probably want to support multiple debuggers we may wish to separate out the gdb jitdebugger support into a separate file. Mind doing that?
No std stream includes :)

-eric