[llvm-commits] [PATCH 04/11] (patch) Mips specific inline asm: constraint 'J'

[Jack Carter]

Integer zero.

main()
{
  unsigned int i_input = 7; unsigned int i_result = 0;

// Good: i_val is 0 which matches the constraint 'J' for it.
  unsigned int i_val = 0;
  __asm__ ("addi %0,%1,%2" : "=r" (i_result)  : "r" (i_input), "J" (i_val));
  printf ("mips_addi(%d,0) = %d\n", i_input, i_result);

// Bad: i_val is not 0 llc should produce an error.
  unsigned int i_val = 3;
  __asm__ ("addi %0,%1,%2" : "=r" (i_result)  : "r" (i_input), "J" (i_val));
  printf ("mips_addi(%d,0) = %d\n", i_input, i_result);
}
---
 lib/Target/Mips/MipsISelLowering.cpp         |   11 +++++++++++
 test/CodeGen/Mips/inlineasm-cnstrnt-bad-J.ll |   14 ++++++++++++++
 test/CodeGen/Mips/inlineasm_constraint.ll    |    6 ++++++
 3 files changed, 31 insertions(+), 0 deletions(-)
 create mode 100644 test/CodeGen/Mips/inlineasm-cnstrnt-bad-J.ll

-------------- next part --------------
diff --git a/lib/Target/Mips/MipsISelLowering.cpp b/lib/Target/Mips/MipsISelLowering.cpp
index 8d46711..b56ed80 100644
--- a/lib/Target/Mips/MipsISelLowering.cpp
+++ b/lib/Target/Mips/MipsISelLowering.cpp
@@ -2927,6 +2927,7 @@ MipsTargetLowering::getSingleConstraintMatchWeight(
       weight = CW_Register;
     break;
   case 'I': // signed 16 bit immediate
+  case 'J': // integer zero
     if (isa<ConstantInt>(CallOperandVal))
       weight = CW_Constant;
     break;
@@ -2990,6 +2991,16 @@ void MipsTargetLowering::LowerAsmOperandForConstraint(SDValue Op,
       }
     }
     return;
+  case 'J': // integer zero
+    if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Op)) {
+      EVT Type = Op.getValueType();
+      int64_t Val = C->getZExtValue();
+      if (Val == 0) {
+        Result = DAG.getTargetConstant(0, Type);
+        break;
+      }
+    }
+    return;
   }
 
   if (Result.getNode()) {
diff --git a/test/CodeGen/Mips/inlineasm-cnstrnt-bad-J.ll b/test/CodeGen/Mips/inlineasm-cnstrnt-bad-J.ll
new file mode 100644
index 0000000..54d8886
--- /dev/null
+++ b/test/CodeGen/Mips/inlineasm-cnstrnt-bad-J.ll
@@ -0,0 +1,14 @@
+;XFAIL:
+;
+;This is a negative test. The constant value given for the constraint (J)
+;is non-zero (3).
+;
+; RUN: not llc -march=mipsel < %s 
+
+
+define i32 @main() nounwind {
+entry:
+  tail call i32 asm "addi $0,$1,$2", "=r,r,J"(i32 1024, i32 3) nounwind
+  ret i32 0
+}
+
diff --git a/test/CodeGen/Mips/inlineasm_constraint.ll b/test/CodeGen/Mips/inlineasm_constraint.ll
index e2fbaa7..f053e0e 100644
--- a/test/CodeGen/Mips/inlineasm_constraint.ll
+++ b/test/CodeGen/Mips/inlineasm_constraint.ll
@@ -15,6 +15,12 @@ entry:
 ; CHECK: #NO_APP
    tail call i32 asm sideeffect "addi $0,$1,$2", "=r,r,I"(i32 7, i32 -3) nounwind
 
+; Now J with 0
+; CHECK: #APP
+; CHECK: addi ${{[0-9]+}},${{[0-9]+}},0
+; CHECK: #NO_APP
+  tail call i32 asm sideeffect "addi $0,$1,$2\0A\09 ", "=r,r,J"(i32 7, i16 0) nounwind
+
   ret i32 0
 }