[llvm-commits] [polly] r153739 - /polly/trunk/test/Makefile

[Sebastian Pop]

On Thu, Apr 5, 2012 at 10:58 PM, Hongbin Zheng <etherzhhb at gmail.com> wrote:
> Hi Sebastian,
>
> Fixed in r154162, sorry for this.
>
> best regards
> ether
> On Fri, Apr 6, 2012 at 5:22 AM, Sebastian Pop <spop at codeaurora.org> wrote:
>> On Fri, Mar 30, 2012 at 4:27 AM, Hongbin Zheng <etherzhhb at gmail.com> wrote:
>>> Author: ether
>>> Date: Fri Mar 30 04:27:16 2012
>>> New Revision: 153739
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=153739&view=rev
>>> Log:
>>> Make the "all" target depend on polly-test, so that users can run regression
>>>  tests by simply typing "make -C tools/polly/test", like llvm's regression
>>>  tests.
>>>
>>> Modified:
>>>    polly/trunk/test/Makefile
>>>
>>> Modified: polly/trunk/test/Makefile
>>> URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Makefile?rev=153739&r1=153738&r2=153739&view=diff
>>> ==============================================================================
>>> --- polly/trunk/test/Makefile (original)
>>> +++ polly/trunk/test/Makefile Fri Mar 30 04:27:16 2012
>>> @@ -31,6 +31,7 @@
>>>   LIT_ARGS += "--vg"
>>>  endif
>>>
>>> +all:: polly-test
>>
>> Several of my automatic tests have failed because of this change: when
>> make has finished building the polly/lib, it automatically goes to
>> make all in the test dir, and because of this change, it starts
>> testing polly, even though the rest of llvm and clang have not
>> finished to be built.
>>
>> Please fix this by not including the test dir in the polly top level
>> Makefile DIRS variable:
> Or do you want to revert this commit?

Yes, let's revert this commit.

>>
>> diff --git a/Makefile b/Makefile
>> index 2ad5b36..665c13a 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -8,7 +8,7 @@
>>  # Indicates our relative path to the top of the project's root directory.
>>  #
>>  LEVEL = .
>> -DIRS = lib test tools
>> +DIRS = lib tools
>>  EXTRA_DIST = include

This change removed the test dir from the build dir, making it impossible to
test Polly with a make polly-test -C tools/polly/test/

What about reverting both this and your previous change?

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum