[llvm-commits] PATCH: Make 'trunc i8 %x to i1' canonical rather than 'icmp ne i8 (and i8 %x, 1), 0'

[Chris Lattner]

On Mar 31, 2012, at 2:00 PM, Chandler Carruth wrote:

> On Fri, Mar 30, 2012 at 1:35 PM, Chris Lattner <clattner at apple.com> wrote:
> On Mar 28, 2012, at 3:37 AM, Chandler Carruth wrote:
> > Currently, when converting an i8 loaded value to an i1 IR value, the canonical pattern is:
> >
> > %x.1 = and i8 %x, 1
> > %x.2 = icmp ne i8 %x, 0
> >
> > This seems really cumbersome. The natural way to represent this is:
> >
> > %x.2 = trunc i8 %x to i1
> >
> > But for some reason instcombine canonicalizes it to the first pattern. I feel like the second pattern is easier to reason about, easier to match in further peep-hole optimizations, easier to fold with surrounding zext operations, and easier to teach codegen to be clever about and eliminate altogether given range metadata. Thoughts? I've attached the trivial change to the code, but the real question is: do we want to do this? Why or why not?
> 
> This was added in r67635:
> 
> "Make instcombine always canonicalize trunc x to i1 into an icmp(x&1).  This
> exposes the AND to other instcombine xforms and is more of what the code
> generator expects."
> 
> The 'trunc to i1' is not legal for any target, and that exposing it to the IR optimizer allows us to simplify and eliminate the and.
> 
> I had read the commit message, but it wasn't clear to me why we couldn't simply let the IR optimizer go to town on the trunc (as well as the and).
> 
> That said, the more I played with this, the less I liked it. The big reason is that at the IR level it is nice to canonicalize a single-bit test, regardless of *which* bit is being tested, into and+icmp. I kept adding more and more special cases, and still not catching all of the optimizations. So the original canonicalization makes more and more sense.
> 
> I think Rafael has a way to get codegen to still turn this into the right low-level instructions inside the dag combiner, so I'll refocus over there.

Sounds good, thanks!

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120401/53f7853f/attachment.html>