[llvm-commits] Review request for test-suite test "unix-smail" disabling

[Chris Lattner]

On Mar 30, 2012, at 4:13 PM, Joel Jones wrote:

> Because the actual time running in user space is so small,
> as compared to I/O:
> 
> exit 0
> real       8.4181
> user       0.2038
> sys        0.0557
> program 0.203816
> 
> Does it make sense to make an enhancement request in Bugzilla
> along the lines of:
> 
> "Restore unix-smail to MultiSource/Benchmarks/Proloangs-C"
> 
> and do the disabling now? 

The test cases in the program test suite are useful for correctness testing as well as performance.  Many of them have a runtime that is too small to be much use for performance testing, but they're still useful for coverage and correctness testing.  It is perfectly fine to change the benchmarks to be more useful for our purposes, so if there is a way to modify it to be useful (for correctness and coverage) I'd prefer that over just disabling it.

-Chris