[llvm-commits] [llvm] r153794 - in /llvm/trunk/utils/TableGen: CodeGenRegisters.cpp CodeGenRegisters.h

[Chandler Carruth]

Tiny coding style nits...

On Fri, Mar 30, 2012 at 6:35 PM, Andrew Trick <atrick at apple.com> wrote:

> --- llvm/trunk/utils/TableGen/CodeGenRegisters.cpp (original)
> +++ llvm/trunk/utils/TableGen/CodeGenRegisters.cpp Fri Mar 30 20:35:59 2012
> @@ -88,6 +88,26 @@
>   return TheDef->getName();
>  }
>
> +// Merge two RegUnitLists maintining the order and removing duplicates.
> +// Overwrites MergedRU in the process.
>

This worth a doxyment? We use them heavily on static functions in Clang,
but I've seen both ways fly in LLVM...


> +static void mergeRegUnits(CodeGenRegister::RegUnitList &MergedRU,
> +                          const CodeGenRegister::RegUnitList &RRU)
> +{
>

curly brace should go after the close paren... at least, i think it fits
there even w/ 80-columns...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120331/e352e300/attachment.html>