[llvm-commits] [llvm] r153558 - /llvm/trunk/runtime/libprofile/GCDAProfiling.c

[Bill Wendling]

On Mar 27, 2012, at 7:22 PM, NAKAMURA Takumi wrote:

> 2012/3/28 Bill Wendling <isanbard at gmail.com>:
>> Author: void
>> Date: Tue Mar 27 20:30:51 2012
>> New Revision: 153558
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=153558&view=rev
>> Log:
>> Use Nakamura's suggestion of bypassing using 'filename' and just the pointers directly.
>> 
>> Modified:
>>    llvm/trunk/runtime/libprofile/GCDAProfiling.c
>> 
>> Modified: llvm/trunk/runtime/libprofile/GCDAProfiling.c
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/runtime/libprofile/GCDAProfiling.c?rev=153558&r1=153557&r2=153558&view=diff
> 
>>    if (!output_file) {
>>      fprintf(stderr, "LLVM profiling runtime: while opening '%s': ",
>>              filename);
> 
> Would you dare to show only the former failed "filename" here?
> Also the latter (derived from orig_filename) ?
> 
Sure. That's not a bad idea. :)

-bw