[llvm-commits] [PATCH] VST1.32 with writeback incorrectly encoded

[Richard Barton]

Hi Jim

Ah yes - that way I can get rid of the messy extra class for the non-writeback version as well. Added an extra regression test for the non-writeback and register writeback versions also.

New patch attached.

Ta,
Rich

> -----Original Message-----
> From: Jim Grosbach [mailto:grosbach at apple.com]
> Sent: 27 March 2012 17:23
> To: Richard Barton
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] VST1.32 with writeback incorrectly encoded
>
> Hi Richard,
>
> Instead of creating a new class, VST1LN32WB, I suggest parameterizing the type
> of $Rn and just passing it in when the defs are instantiated. You can see
> examples on the various classes that accept an "Operand" type operand.
>
> -Jim
>
>
> On Mar 27, 2012, at 5:55 AM, Richard Barton <richard.barton at arm.com> wrote:
>
> > Hello
> >
> > The following is the instruction being encoded incorrectly by clang
> > -integrated-as
> >
> > vst1.32 {d27[1]}, [r9, :32]!
> >
> > GNU assembler encodes this as
> >
> > f4c9b8bd            vst1.32 {d27[1]}, [r9 :32]!
> >
> > LLVM encodes this as (llvm-mc output)
> >
> > vst1.32 {d27[1]}, [r9, :32]!    @ encoding: [0x9d,0xb8,0xc9,0xf4]
> >
> > Notice that the last byte encoding is wrong; it should be 0xbd instead of
> 0x9d
> >
> > The problem is that there is a special tablegen class for VST1.32 which does
> not
> > have a writeback version. This is a simple patch to add this class, with a
> > regression test for this instruction encoding.
> >
> > Please review
> >
> > Regards,
> > Richard Barton<vst1.32.patch>
>
>


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vst1.32_version2.patch
Type: application/octet-stream
Size: 4524 bytes
Desc: vst1.32_version2.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120327/25e6663b/attachment.obj>