[llvm-commits] [llvm] r153207 - /llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h

[Danil Malyshev]

Hello,


I am very apologize, I fixed it now in r153208, after testing.
Just prepared two next linked patches and tested it together with move_getPointerToNamedFunction-01.patch. 
Thank you!



Regards,
Danil

-----Original Message-----
From: Benjamin Kramer [mailto:benny.kra at googlemail.com] 
Sent: Wednesday, March 21, 2012 11:00 PM
To: Danil Malyshev
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r153207 - /llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h


On 21.03.2012, at 19:47, Danil Malyshev wrote:

> Author: danil
> Date: Wed Mar 21 13:47:10 2012
> New Revision: 153207
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=153207&view=rev
> Log:
> Missed getPointerToNamedFunction() declaration.
> 
> Modified:
>    llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h
> 
> Modified: llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h?rev=153207&r1=153206&r2=153207&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h (original)
> +++ llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h Wed Mar 21 13:47:10 2012
> @@ -54,6 +54,10 @@
>   // memory was actually used.
>   virtual void endFunctionBody(const char *Name, uint8_t *FunctionStart,
>                                uint8_t *FunctionEnd) = 0;
> +
> +  
> +  virtual void *getPointerToNamedFunction(const std::string &Name,
> +                                          bool AbortOnFailure = true) = 0;
> };
> 
> class RuntimeDyld {

Still broken:

MCJIT.cpp:48:38: error: allocating an object of abstract class type 'MCJITMemoryManager'
    return new MCJIT(M, TM, *TJ, new MCJITMemoryManager(JMM, M), GVsWithCode);
                                     ^
include/llvm/ExecutionEngine/RuntimeDyld.h:59:17: note: unimplemented pure virtual method
      'getPointerToNamedFunction' in 'MCJITMemoryManager'
  virtual void *getPointerToNamedFunction(const std::string &Name,
                ^

- Ben