[llvm-commits] Move getPointerToNamedFunction() from JIT/MCJIT to JITMemoryManager.

[Kaylor, Andrew]

Hi Danil,

It isn't entirely clear to me what the old expected behavior was, but the fact that you had to update the tests seems like a red flag.

There are likely other users of this code who are creating JIT execution engines without creating a memory manager.  I think it would be better to have the JIT constructor create a default memory manager if NULL is passed in for that argument.

The check for a null JMM before use in getPointerToNamed function is good, but the function will still likely fail in many cases if JMM is null.

-Andy

From: Danil Malyshev [mailto:dmalyshev at accesssoftek.com]
Sent: Thursday, March 22, 2012 3:56 PM
To: llvm-commits at cs.uiuc.edu; Jim Grosbach; Kaylor, Andrew
Subject: RE: [llvm-commits] Move getPointerToNamedFunction() from JIT/MCJIT to JITMemoryManager.

Hello everyone,


The move_getPointerToNamedFunction-01.patch has causing failures in the LazyLoadedJITTest.MaterializableAvailableExternallyFunctionIsntCompiled and MultiJitTest.JitPool unit tests.
This tests uses JIT.getPointerToNamedFunctions() for JIT with NULL memory manager, so call JMM->getPointerToNamedFunctions() raise exception.
This patch move the implementation of getPointerToNamedFunctions from JIT to defaultJMM, so I think, the best way is change this tests to use JIT with default memory manager.
Please review attached move_getPointerToNamedFunction-02.patch with these changes.
For easily looking I also attached the changes.diff. It's contains only changes linked with the problem.

Tested in Ubuntu 64 and Mac OS 64.


Regards,
Danil


________________________________
From: Danil Malyshev
Sent: Wednesday, March 21, 2012 10:41 PM
To: 'Jim Grosbach'
Cc: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: RE: [llvm-commits] Move getPointerToNamedFunction() from JIT/MCJIT to JITMemoryManager.

Hello,


Committed at r153205, thank you.



Regards,
Danil

________________________________
From: Jim Grosbach [mailto:grosbach at apple.com]
Sent: Wednesday, March 21, 2012 1:46 AM
To: Danil Malyshev
Cc: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Re: [llvm-commits] Move getPointerToNamedFunction() from JIT/MCJIT to JITMemoryManager.

LGTM. Thanks!
On Mar 20, 2012, at 11:48 AM, Danil Malyshev <dmalyshev at accesssoftek.com<mailto:dmalyshev at accesssoftek.com>> wrote:

Hello everyone,

Based on this discussion: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120305/138477.html
Please find attached the patch for review.
This patch doing following:
1. Declares a virtual function getPointerToNamedFunction() in JITMemoryManager
2. Moves the implementation of getPointerToNamedFunction() form JIT/MCJIT to DefaultJITMemoryManager.


Regards,
Danil
<move_getPointerToNamedFunction-01.patch>_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120323/d7865bf4/attachment.html>