[llvm-commits] Review Request: Use SmallPtrSetImpl instead of SmallPtrSet in funciton IVUsers::AddUsersIfInteresting

Andrew Trick atrick at apple.com
Fri Mar 16 11:11:32 PDT 2012


On Mar 16, 2012, at 1:21 AM, Hongbin Zheng <etherzhhb at gmail.com> wrote:

> hi,
> 
> This patch let the user to decide the default size of the SmallPtrSet
> which is passed to IVUsers::AddUsersIfInteresting.
> 
> best regards
> ether
> 
> [PATCH] Refactor: Use SmallPtrSetImpl instead of SmallPtrSet as the
> argument type of funciton IVUsers::AddUsersIfInteresting,
> let the user decide the   default size.

Yep. I normally do that. I was under some strange impression last night that SmallPtrSetImpl wasn't a template. Please check in, and you can simultaneously fix the polly branch.

Incidentally, the only reason I didn't hide the SmallPtrSet argument behind the API is that all the callers outside IVUsers will be removed from the codebase soon.

-Andy



More information about the llvm-commits mailing list