[llvm-commits] [llvm] r152620 - in /llvm/trunk: ./ autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/ lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/ lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/ un

[Bendersky, Eli]

Committed in r152780

From: Malea, Daniel
Sent: Wednesday, March 14, 2012 23:25
To: Nick Lewycky; Bendersky, Eli
Cc: llvm-commits at cs.uiuc.edu
Subject: RE: [llvm-commits] [llvm] r152620 - in /llvm/trunk: ./ autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/ lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/ lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/ un

Hi Nick,

Thanks for noticing the (incorrect) test move. I must apologize as I'm responsible for moving those tests for no good reason. Another patch I was working on snuck into this one...

The attached patch has the build system modifications required to move the JITEventListener test back in the JIT directory where it belongs, as well as the other tests that depend on JIT: IntelJITEventListenerTest and OProfileJITEventListenerTest.

I don't have commit access, so I can't actually commit the fix. Whoever commits it must also do:
$ svn mv unittests/ExecutionEngine/JITEventListenerTest.cpp unittests/ExecutionEngine/IntelJITEventListenerTest.cpp unittests/ExecutionEngine/OProfileJITEventListenerTest.cpp unittests/ExecutionEngine/JITEventListenerTestCommon.h unittests/ExecutionEngine/JIT/

Thanks,
Dan

From: llvm-commits-bounces at cs.uiuc.edu<mailto:llvm-commits-bounces at cs.uiuc.edu> [mailto:llvm-commits-bounces at cs.uiuc.edu]<mailto:[mailto:llvm-commits-bounces at cs.uiuc.edu]> On Behalf Of Nick Lewycky
Sent: Tuesday, March 13, 2012 5:00 PM
To: Bendersky, Eli
Cc: llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
Subject: Re: [llvm-commits] [llvm] r152620 - in /llvm/trunk: ./ autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/ lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/ lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/ un

On 13 March 2012 01:33, Eli Bendersky <eli.bendersky at intel.com<mailto:eli.bendersky at intel.com>> wrote:
Author: eliben
Date: Tue Mar 13 03:33:15 2012
New Revision: 152620

URL: http://llvm.org/viewvc/llvm-project?rev=152620&view=rev
Log:
Add profiling support for Intel Parallel Amplifier XE (VTune) for JITted code in LLVM.

Also refactor the existing OProfile profiling code to reuse the same interfaces with the VTune profiling code.
In addition, unit tests for the profiling interfaces were added.

This patch was prepared by Andrew Kaylor and Daniel Malea, and reviewed in the llvm-commits list by Jim Grosbach


Added:
   llvm/trunk/include/llvm/ExecutionEngine/IntelJITEventsWrapper.h
   llvm/trunk/include/llvm/ExecutionEngine/OProfileWrapper.h
   llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h
   llvm/trunk/lib/ExecutionEngine/IntelJITEvents/
   llvm/trunk/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt
   llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
   llvm/trunk/lib/ExecutionEngine/IntelJITEvents/LLVMBuild.txt
   llvm/trunk/lib/ExecutionEngine/IntelJITEvents/Makefile
   llvm/trunk/lib/ExecutionEngine/OProfileJIT/
   llvm/trunk/lib/ExecutionEngine/OProfileJIT/CMakeLists.txt
   llvm/trunk/lib/ExecutionEngine/OProfileJIT/LLVMBuild.txt
   llvm/trunk/lib/ExecutionEngine/OProfileJIT/Makefile
   llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp
   llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileWrapper.cpp
   llvm/trunk/unittests/ExecutionEngine/IntelJITEventListenerTest.cpp
   llvm/trunk/unittests/ExecutionEngine/JITEventListenerTest.cpp

This is the first test in unittests/ExecutionEngine that relies on the JIT, the rest are all in ExecutionEngine/JIT. This is not a huge problem (it's just unit tests after all) so it's not a layering violation per se, but it is odd enough that our build system noticed it.

Is there any reason that test shouldn't be in the ExecutionEngine/JIT directory?

Actually it looks like you left ExecutionEngine/JIT/JITEventListenerTest.cpp an empty file. Please fix!

Nick

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120315/ff52aea8/attachment.html>