[llvm-commits] PATCH: Enable avoiding eager inlining for linkonce-ODR functions

[Eric Christopher]

On Mar 14, 2012, at 10:33 AM, Chandler Carruth <chandlerc at gmail.com> wrote:

> Also re-sending patch since apparently email threading is hard. ;]
> 
> On Wed, Mar 14, 2012 at 10:13 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> Ping (and CC duncan so he sees this one)
> 
> 
> On Tue, Mar 13, 2012 at 2:38 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> On Mon, Mar 12, 2012 at 9:44 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> I ran a range of Google-specific benchmarks, and saw a geo-mean improvement of runtime of 0.4%. Some benchmarks improved as much as 2%, others didn't improve. I also found an average (and total) size increase of 2% across these benchmarks, so it's not trivially a win. This is a bit of a tradeoff.
> 
> FWIW, the clang binary does not get any larger with this change, and I'm seeing about 1% improvement in compile times.

Seems reasonable. Be worth putting it through the paces via nightly.

-eric