[llvm-commits] [PATCH] [msvc] Honor %INCLUDE%. It should know essential search paths with vcvarsall.bat.

[Michael Spencer]

On Mon, Mar 12, 2012 at 8:42 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> FYI,
>
> On VS10, %INCLUDE% contains;
> (VS10)\VC\INCLUDE
> (VS10)\VC\ATLMFC\INCLUDE
> (SDK70A)\include
>
> On VS11,
> (VS11)\VC\INCLUDE
> (VS11)\VC\ATLMFC\INCLUDE
> (SDK80)\include\shared
> (SDK80)\include\um
> (SDK80)\include\winrt
> ---
>  clang/lib/Driver/WindowsToolChain.cpp |   18 +++++++++++++++++-
>  llvm/utils/lit/lit/TestingConfig.py   |    1 +
>  2 files changed, 18 insertions(+), 1 deletions(-)

The patch looks fine, the only thing I worry about is this code not
being accessible from a MinGW built Clang. I'd rather we restructure
the surrounding code to be enabled if we are both hosted on Windows,
and targeting Win32.

- Michael Spencer