[llvm-commits] [lld] r152388 - /lld/trunk/lib/Core/NativeWriter.cpp

Michael J. Spencer bigcheesegs at gmail.com
Thu Mar 8 21:27:21 PST 2012


Author: mspencer
Date: Thu Mar  8 23:27:20 2012
New Revision: 152388

URL: http://llvm.org/viewvc/llvm-project?rev=152388&view=rev
Log:
StringRef is not null terminated.

Modified:
    lld/trunk/lib/Core/NativeWriter.cpp

Modified: lld/trunk/lib/Core/NativeWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/NativeWriter.cpp?rev=152388&r1=152387&r2=152388&view=diff
==============================================================================
--- lld/trunk/lib/Core/NativeWriter.cpp (original)
+++ lld/trunk/lib/Core/NativeWriter.cpp Thu Mar  8 23:27:20 2012
@@ -345,8 +345,8 @@
     if ( name.empty() )
       return 0;
     uint32_t result = _stringPool.size();
-    _stringPool.insert(_stringPool.end(), name.size()+1, 0);
-    strcpy(&_stringPool[result], name.data());
+    _stringPool.insert(_stringPool.end(), name.begin(), name.end());
+    _stringPool.push_back(0);
     return result;
   }
 





More information about the llvm-commits mailing list