[llvm-commits] Fix LLVM to emit 16-bit CMN when targeting ARM Thumb2 ISA

Zino Benaissa zinob at codeaurora.org
Tue Mar 6 09:23:47 PST 2012


Hi Anton, 

In file "test/CodeGen/Thumb2/thumb2-cmn.ll", there are already testcases that test complex cmn wide forms (cmn in with shift). 
It is   not easy to force the operands of cmn to be r8-r12 and at the same time keep it consistent over time. 

Other solution suppress Thumb2 size reduction pass? Any thoughts?

Thanks, 

-Zino 
-----Original Message-----
From: Anton Korobeynikov [mailto:anton at korobeynikov.info] 
Sent: Thursday, February 23, 2012 11:28 AM
To: Sebastian Pop
Cc: llvm-commits at cs.uiuc.edu; James Molloy; Zino Benaissa
Subject: Re: [llvm-commits] Fix LLVM to emit 16-bit CMN when targeting ARM Thumb2 ISA

Hi Sebastian,

>>> I would like to ping this patch: could one of the ARM maintainers 
>>> please review the attached patch?
>> Sorry, I completely missed this patch. I will try to review it tonight.
>
> Ping^2.  Could somebody review the attached patch?
Sorry for delay. Generally patch is ok, but will it possible somehow to include testcases for selection of  wide versions as well?

--
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University





More information about the llvm-commits mailing list