[llvm-commits] AddressSanitizer: Make GetOSVersion available on all platforms (issue 5702060)

kcc at google.com kcc at google.com
Wed Feb 29 07:31:51 PST 2012


http://codereview.appspot.com/5702060/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5702060/diff/1/asan_interceptors.cc#newcode623
asan_interceptors.cc:623: if (GetOSVersion() == MACOS_LION) {
Do you have any other reason for this function except for this if
statement?
For this statement, I would prefer something like
   if (PlatformHasDifferentMemcpyAndMemmove)


BTW, Maybe it's better to implement internal_memcpy?
(It will have to be highly performant)

http://codereview.appspot.com/5702060/



More information about the llvm-commits mailing list