[llvm-commits] Enable -Wcovered-switch-default in our builds

Kay Tiong Khoo kkhoo at perfwizard.com
Tue Feb 28 09:35:05 PST 2012


TOT is now broken building with GCC 4.0 on OSX:
llvm[1]: Compiling raw_ostream.cpp for Debug+Asserts build
warning: unknown warning option '-Wcovered-switch-default'
[-Wunknown-warning-option]
1 warning generated.
llvm[1]: Compiling regcomp.c for Debug+Asserts build
cc1: error: unrecognized command line option "-Wcovered-switch-default"


2012/2/28 Daniel Dunbar <daniel at zuster.org>

> Hi Rafael,
>
> It turns out that your configure check doesn't work as intended with
> Clang, because Clang doesn't error out on unknown warning options.
>
> This makes the build have a lot of warning spew when building with an
> older version of Clang.
>
> Can you see about fixing CXX_FLAG_CHECK to handle this case?
>
>  - Daniel
>
> 2012/2/27 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:
> > While  -Wcovered-switch-default was found to be too noisy to most
> > projects, it matches our coding style. The attached patch enables it
> > in our builds. Is it OK?
> >
> > Cheers,
> > Rafael
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120228/04398cd8/attachment.html>


More information about the llvm-commits mailing list