[llvm-commits] Enable -Wcovered-switch-default in our builds

[Daniel Dunbar]

2012/2/27 David Blaikie <dblaikie at gmail.com>:
> 2012/2/27 Rafael Espíndola <rafael.espindola at gmail.com>:
>> While  -Wcovered-switch-default was found to be too noisy to most
>> projects, it matches our coding style. The attached patch enables it
>> in our builds. Is it OK?
>
> Out of curiosity - we turn on a bunch of other warninngs (-Wall and
> -Wwrite-strings) by default without configure options in the Makefile
> - is it worth plumbing this through as optional like this, rather than
> just turning it on by default in the same way?

Yes, it is really annoying to get loads of compiler warnings when
building with an older version of Clang.

 - Daniel

> (& thanks for doing this, in any case)
>
> Another thing we had been discussing was moving this option under
> -Wall, but that never really got fully hashed out.
>
> - David
>
>>
>> Cheers,
>> Rafael
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits