[llvm-commits] [llvm] r151584 - in /llvm/trunk: lib/Analysis/BasicAliasAnalysis.cpp test/Analysis/BasicAA/global-size.ll

[Eli Friedman]

Author: efriedma
Date: Mon Feb 27 17:16:46 2012
New Revision: 151584

URL: http://llvm.org/viewvc/llvm-project?rev=151584&view=rev
Log:
Duncan pointed out that if the alignment isn't explicitly specified, it defaults to the ABI alignment.  Given that, make this code a bit more aggressive in such cases.

Modified:
    llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
    llvm/trunk/test/Analysis/BasicAA/global-size.ll

Modified: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=151584&r1=151583&r2=151584&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Mon Feb 27 17:16:46 2012
@@ -120,11 +120,11 @@
     return AliasAnalysis::UnknownSize;
 
   uint64_t Size = TD.getTypeAllocSize(AccessTy);
-  if (RoundToAlign) {
-    if (!Align)
-      return AliasAnalysis::UnknownSize;
+  // If there is an explicitly specified alignment, and we need to
+  // take alignment into account, round up the size. (If the alignment
+  // is implicit, getTypeAllocSize is sufficient.)
+  if (RoundToAlign && Align)
     Size = RoundUpToAlignment(Size, Align);
-  }
 
   return Size;
 }

Modified: llvm/trunk/test/Analysis/BasicAA/global-size.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/global-size.ll?rev=151584&r1=151583&r2=151584&view=diff
==============================================================================
--- llvm/trunk/test/Analysis/BasicAA/global-size.ll (original)
+++ llvm/trunk/test/Analysis/BasicAA/global-size.ll Mon Feb 27 17:16:46 2012
@@ -4,7 +4,7 @@
 ; RUN: opt < %s -basicaa -gvn -S | FileCheck %s
 target datalayout = "E-p:64:64:64-a0:0:8-f32:32:32-f64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-v64:64:64-v128:128:128"
 
- at B = global i16 8, align 2
+ at B = global i16 8
 
 ; CHECK: @test1
 define i16 @test1(i32* %P) {