[llvm-commits] [PATCH] Fix undefined behavior in the Mips backend

Akira Hatanaka ahatanak at gmail.com
Fri Feb 24 11:43:24 PST 2012


I think the possibility of undefined behavior remains even after
applying the patch, since the uint64_t value is converted to int64_t
when it is passed to GetInstSeqLs. Is that right?

If that is the case, all functions should take "uint64_t Imm" instead
of "int64_t Imm" as you have suggested.

On Fri, Feb 24, 2012 at 2:30 AM, Ahmed Charles <ahmedcharles at gmail.com> wrote:
> This patch maintains current behavior while avoiding UB. I'd like
> someone with more understanding of the Mips backend to suggest whether
> all of these functions should take a uint64_t or not, since they are
> just representing 'bits', rather than signed values.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list